Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[token cli]: add support for group member pointer #5912

Merged
merged 3 commits into from
Nov 29, 2023
Merged

[token cli]: add support for group member pointer #5912

merged 3 commits into from
Nov 29, 2023

Conversation

buffalojoec
Copy link
Contributor

This PR adds support to the SPL Token CLI for Token Group Member Pointer!

@buffalojoec Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@buffalojoec buffalojoec mentioned this pull request Nov 28, 2023
Merged
@buffalojoec buffalojoec force-pushed the 11-28-_token_cli_add_support_for_group_member_pointer branch from 08a0c50 to 08ba353 Compare November 28, 2023 21:31
joncinque
joncinque reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good here too! Just a few small points

token/cli/src/clap_app.rs Outdated Show resolved Hide resolved
token/cli/src/clap_app.rs Show resolved Hide resolved
token/cli/src/command.rs Outdated Show resolved Hide resolved
token/cli/src/command.rs Outdated Show resolved Hide resolved
token/cli/src/command.rs Outdated Show resolved Hide resolved
token/cli/tests/command.rs Outdated Show resolved Hide resolved
token/cli/tests/command.rs Show resolved Hide resolved
@buffalojoec buffalojoec force-pushed the 11-28-_token_cli_add_support_for_group_member_pointer branch 2 times, most recently from 405a508 to 846448d Compare November 29, 2023 17:14
joncinque
joncinque previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point

@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Nov 29, 2023 •
edited
Loading

Merge activity

  • Nov 29, 12:49 PM: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Nov 29, 12:49 PM: Graphite rebased this pull request as part of a merge.
  • Nov 29, 12:50 PM: @buffalojoec merged this pull request with Graphite.

Base automatically changed from 11-28-_token_cli_add_support_for_group_pointer to master November 29, 2023 17:49
@buffalojoec buffalojoec force-pushed the 11-28-_token_cli_add_support_for_group_member_pointer branch from 846448d to f36781f Compare November 29, 2023 17:49
@mergify mergify bot dismissed joncinque’s stale review November 29, 2023 17:49

Pull request has been modified.

@buffalojoec buffalojoec merged commit ad86abe into master Nov 29, 2023
28 checks passed
@buffalojoec buffalojoec deleted the 11-28-_token_cli_add_support_for_group_member_pointer branch November 29, 2023 17:50
@buffalojoec buffalojoec mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque