Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify that token-2022 is ready and eligible for bounties #6084

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

joncinque
Copy link
Contributor

Problem

Token-2022 has finished its audits for version 1.0.0, making it eligible for bug bounties, but the documentation is out of date.

Solution

Say that token-2022 is ready!

@joncinque joncinque requested review from t-nelson and federaa January 8, 2024 17:47
Comment on lines 5 to 7
The Token-2022 program is ready for full production use. All clusters have the
latest program deployed **without confidential transfer functionality**.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems more like a temporary "announcement" than something that needs to live in the docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about I get rid of the first sentence? At least knowing what's deployed should be pretty useful

Comment on lines 11 to 15
The program is ready for full production use. All clusters have the latest
program deployed **without confidential transfer functionality**.

The program with confidential transfer functionality will be deployed once
Solana v1.17 reaches mainnet-beta with the appropriate syscalls enabled. See the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replicode? maybe just replace with a spruced up link out to the status?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point... We had it here as extra cover-your-ass to be really clear that it wasn't ready for prod. we could just remove the whole thing, what do you think?

@@ -138,8 +141,8 @@ For information about the types and instructions, the Rust docs are available at

## Security Audits

The Token-2022 Program is currently under multiple audits to ensure safety of
funds. All audits will be published here as they are completed.
The Token-2022 Program has been audited multiple times to ensure safety of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the lawyers cool with this language? audits don't "ensure" anything. :trollface:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof yeah, that's a good point, I'll just say it's been audited multiple times

@joncinque joncinque merged commit 56aaa67 into solana-labs:master Jan 9, 2024
9 checks passed
@joncinque joncinque deleted the tk22sec branch January 9, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants