-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token-2022: repair offchain extra metas helper #6088
token-2022: repair offchain extra metas helper #6088
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
eaf4c89
to
73724a8
Compare
73724a8
to
ce7a81e
Compare
ce7a81e
to
c03c8df
Compare
c03c8df
to
a9cda55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guts look great! I think we might be able to make the interface clearer, and otherwise, mostly small points
Thanks for the review @joncinque! If you're not opposed, I think I'll rewrite some of this commit history to shuffle around changes, rather than push up several new ones. Lmk. |
Yep, works for me! |
Closing in favor of the new stack at #6099 - all comments here resolved there. |
This stack introduces the necessary repairs to Token2022's extra account metas
helpers in order to solve the issue reported in #6064.
In this particular PR, Token2022's offchain helper is being repaired by first
adding the necessary steps to build an
Execute
instruction instead ofresolving on a transfer instruction. Then, this introduces a new function that
takes all of the parameters for
instruction::transfer_checked(..)
, to ensurewe are not getting the wrong instruction, as suggested by @joncinque in this PR
comment.
The commit flow is as follows:
refactor a transfer hook test in
program-2022-test
.