token-js: add COption<Pubkey>
support to InitializeTransferFeeConfig
instruction
#6164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InitializeTransferFeeConfig
instruction in Token2022's Rust crate expects aCOption<Pubkey>
, which denotesNone
with a single0
andSome(Pubkey)
with a1
followed by the public key bytes.The layout for this instruction in Token JS -
initializeTransferFeeConfigInstructionData
- was incorrectly using 32 all-zero bytes forNone
, as one might do with anOptionalNonZeroPubkey
. This was causing incorrect instruction data when one of the two authorities was set tonull
.Here I've introduced a
COptionPublicKeyLayout
serialization layout to use for this kind of case. It will handle the properCOption<Pubkey>
. encoding and decoding, so we encode and decode instructions properly!Closes #6113