-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I think we also need to bump this crate to v2.0.1 for release, right?
Pull request has been modified.
I'm actually surprised we haven't run into this before. @joncinque , have you seen any conflict issues trying to publish spl-token-2022 in the past? The token-group-interface and token-metadata-interface dependencies are probably pretty new to the monorepo, but memo has been in there forever. This is what the conflict looked like, incidentally:
I'm just sort of confused that we didn't see the same error publishing spl-token-2022 v0.9.0, which specifies spl-memo v4, when monorepo was on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't hurt to get @joncinque 's sanity check, if he's around
Sorry for the late response, but it looks good! And I think we got lucky beforehand because cargo does support multiple concurrent major versions in some situations. So it's valid for token-2022 to use memo v4 and the monorepo to use memo v3, but it's not valid for monorepo to require |
Oh, cargo, you make no sense to my feeble human brain sometimes |
In preparation for bumping the monorepo version to 2.0.0, relax some of the internal dependencies.