Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add token group extension in token #6295

Merged
merged 10 commits into from
Mar 22, 2024
Merged

feat: add token group extension in token #6295

merged 10 commits into from
Mar 22, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Feb 25, 2024 •
edited by buffalojoec
Loading

As mentioned in #6175, add support for token group extension to @solana/spl-token

Todo

  • e2e tests
  • unit tests

@mergify mergify bot added the community Community contribution label Feb 25, 2024
buffalojoec
buffalojoec reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

I left a few suggestions and revisions, and it would be great to have a unit test similar to that of TokenMetadata for creating groups and members!

Thanks for contributing! 🔥

single-pool/js/packages/modern/.gitignore Outdated Show resolved Hide resolved
token/js/src/extensions/groupMember/actions.ts Outdated Show resolved Hide resolved
token/js/src/extensions/groupMember/actions.ts Outdated Show resolved Hide resolved
token/js/src/extensions/group/state.ts Outdated Show resolved Hide resolved
token/js/src/extensions/groupMember/state.ts Outdated Show resolved Hide resolved
token/js/src/extensions/index.ts Outdated Show resolved Hide resolved
token/js/src/extensions/group/actions.ts Outdated Show resolved Hide resolved
token/js/test/e2e-2022/group.test.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the stale [bot only] Added to stale content; will be closed soon label Mar 15, 2024
@github-actions github-actions bot closed this Mar 22, 2024
@buffalojoec
Copy link
Contributor

Hey @qiweiii, still working on this?

@qiweiii
Copy link
Contributor Author

qiweiii commented Mar 22, 2024

Hi, I was having trouble fixing the groupMember test. I may not be able to finish this soon. It would be great if you could help commit to this branch directly

@buffalojoec buffalojoec reopened this Mar 22, 2024
@buffalojoec buffalojoec force-pushed the feat/support-token-group branch from aff16a1 to 212de28 Compare March 22, 2024 16:18
@buffalojoec buffalojoec force-pushed the feat/support-token-group branch from 212de28 to 9516d79 Compare March 22, 2024 16:26
@buffalojoec buffalojoec force-pushed the feat/support-token-group branch from bd052b9 to 49ee78e Compare March 22, 2024 16:42
buffalojoec
buffalojoec approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handoff!

handoff

@buffalojoec buffalojoec marked this pull request as ready for review March 22, 2024 16:47
@buffalojoec buffalojoec merged commit 56b083d into solana-labs:master Mar 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees
No one assigned
Labels
community Community contribution stale [bot only] Added to stale content; will be closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiweiii @buffalojoec