[token-js] Fix confidential transfer extensions account length #6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The confidential transfer extension in token-js has not been updated for a while. Currently, the wrong lengths for the confidential transfer mint and accounts are hard-coded in. Although confidential transfers are not yet supported in token-js, this could be quite confusing (e.g. #6338).
Summary of changes
Hard-code the mint and account lengths with the correct number. These should be replaced with the
confidentialTransferMint.spanandconfidentialTransferAccount.spanas soon as wasm support for zk-token-sdk lands.