Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pnpm setup #6979

Merged
merged 1 commit into from
Jul 5, 2024
Merged

ci: update pnpm setup #6979

merged 1 commit into from
Jul 5, 2024

Conversation

liby
Copy link
Contributor

@liby liby commented Jul 4, 2024

@mergify mergify bot added the community Community contribution label Jul 4, 2024
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! How about just removing the:

with:
  version: 8

Bit everywhere since the version is specified in the package.json?

@liby
Copy link
Contributor Author

liby commented Jul 5, 2024

Thanks for your contribution! How about just removing the:

with:
  version: 8

Bit everywhere since the version is specified in the package.json?

That's better. According to the document description of pnpm/action-setup

Omit version input to use the version in the packageManager field in the package.json.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for fixing this up!

@joncinque joncinque merged commit e67b3f2 into solana-labs:master Jul 5, 2024
38 checks passed
@liby liby deleted the bugfix/update-pnpm-setup branch July 6, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants