Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token-group: Increase max size type to u64 #7130

Merged

Conversation

jacksondoherty
Copy link
Contributor

@jacksondoherty jacksondoherty commented Aug 11, 2024

Resolves #7061

Breaking Changes

  • token-group/js: bigint used for maxSize and memberNumber
  • token/js: bigint used for maxSize

Notes

  • I didn't update version numbers in package.json or the pnpm-lock.yaml file, it appears you all have a process for that.
  • @buffalojoec I'm not sure if I ran into the issue you mentioned regarding the "extension state layout's alignment." The e2e tests appear to be working, but if you can elaborate a bit more on this I'm happy to make sure it's covered!

@mergify mergify bot added the community Community contribution label Aug 11, 2024
@jacksondoherty jacksondoherty force-pushed the increase-token-group-max-size branch from a2e9b97 to 9b4ea2b Compare August 11, 2024 17:45
@jacksondoherty jacksondoherty marked this pull request as ready for review August 11, 2024 17:45
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacksondoherty - the changes look great! For the libraries, we'll follow the expected release cadence to publish the new changes, but we need to sort out what to do about the on-chain program (Token-2022) itself, since the feature for token-group was planned to be activated soon. There's a few things in-flight we need to sort out, then I can circle back here to merge this and get it in.

Thanks for throwing this together!

@jacksondoherty
Copy link
Contributor Author

Awesome, sounds good! Selfishly, I'm hoping this makes it on-chain as early as possible for my own projects. Let me know if there is any more help you need regarding things in-flight!

@buffalojoec buffalojoec mentioned this pull request Aug 15, 2024
@buffalojoec
Copy link
Contributor

@jacksondoherty going in, thanks again!

@buffalojoec buffalojoec merged commit dc89cbe into solana-labs:master Aug 20, 2024
44 checks passed
@jacksondoherty jacksondoherty deleted the increase-token-group-max-size branch August 21, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Use u64 for Token-Group Interface max_size
2 participants