add short createAssociatedTokenAccountIdempotentInstruction #7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Aug 22, 2024
| ) { | ||
| const associatedToken = getAssociatedTokenAddressSync(mint, owner, allowOwnerOffCurve); | ||
|
|
||
| return createAssociatedTokenAccountIdempotentInstruction(payer, owner, mint, programId, associatedTokenProgramId); |
There was a problem hiding this comment.
This isn't using the associated token account address that was just derived, so it's incorrect. You'll need to do:
Suggested change
| return createAssociatedTokenAccountIdempotentInstruction(payer, owner, mint, programId, associatedTokenProgramId); | |
| return createAssociatedTokenAccountIdempotentInstruction(payer, associatedToken, owner, mint, programId, associatedTokenProgramId); |
| * | ||
| * @return Instruction to add to a transaction | ||
| */ | ||
| export function createAssociatedTokenAccountIdempotentInstructionShort( |
There was a problem hiding this comment.
nit: can we rename this to something a bit clearer? maybe createAssociatedTokenAccountIdempotentInstructionWithDerivation?
| @@ -64,6 +65,31 @@ export function createAssociatedTokenAccountIdempotentInstruction( | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Construct a createAssociatedTokenAccountIdempotentInstructionShort instruction | |||
There was a problem hiding this comment.
nit: let's keep the comment correct
Suggested change
| * Construct a createAssociatedTokenAccountIdempotentInstructionShort instruction | |
| * Derive the associated token account and construct a CreateAssociatedTokenAccountIdempotent instruction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7178