This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
ci: Remove all references to twoxtx #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to unblock CI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that the curve25519-dalek upgrade has landed on agave with anza-xyz/agave#2252, the twoxtx build is failing https://github.com/solana-labs/solana-program-library/actions/runs/10682051895/job/29607007216?pr=7233, which makes sense since SPL isn't using the newest curve25519-dalek crate yet.
Summary of changes
As we discovered last year, all of the token-2022 tests are going through banks-client / banks-server, which doesn't take into account size limits for transactions. This means that we don't need to do a special 2xTx build at all.
Remove all references to twoxtx.