resolved-conflict in spl-noop and spl-account-compression #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mubarizkyc
changed the title
mubarizkyc
changed the title
|
The js/ts side is failing as it looks like it also requires updated to anchor 0.30.1. That update is not straightforward and produces more problems with tooling to generate the client code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was a confusion b/w anchor and solana PubKey in spl-noop and spl-account-compression which was probably arising from solana-program version conflict b/w spl-noop and anchor-lang 0.30.1 in spl-account-compression
As a Solution ,directly implementing spl-noop functionalities in spl-account-compression resolved the conflict
fix #7247
fix #7248