token-cli: Add confirm-tx timeout to RPC client #7484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem As noticed with solana-labs#7456, a transaction with a nonced blockhash fails to confirm even though it works. This might be because of the confirmation logic in the RPC client, which looks for the provided blockhash: https://github.com/anza-xyz/agave/blob/b46c87ea538a1508ed4ae36f8dbf6c75dd57c883/rpc-client/src/nonblocking/rpc_client.rs#L1090 #### Summary of changes Specify a default transaction confirmation timeout.
brooksprumo
reviewed
Nov 12, 2024
| @@ -97,9 +100,11 @@ impl<'a> Config<'a> { | |||
| .unwrap_or(&cli_config.json_rpc_url), | |||
| ); | |||
| let websocket_url = solana_cli_config::Config::compute_websocket_url(&json_rpc_url); | |||
| let rpc_client = Arc::new(RpcClient::new_with_commitment( | |||
There was a problem hiding this comment.
What is the old behavior when these default timeouts are not set?
There was a problem hiding this comment.
30 seconds for rpc (which is what this PR uses), and none for the other one, which is why I thought it was the issue
There was a problem hiding this comment.
Looking at the code, does at none effectively mean we have a timeout of zero, i.e. we'll only check once and never check again for transaction confirmation?
There was a problem hiding this comment.
Seems reasonable to me. Is there a way for the client to override this default?
There was a problem hiding this comment.
Not with this PR. I wanted to keep it simple here, and only add a command-line arg if anyone ever needs it in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noticed with #7456, a transaction with a nonced blockhash fails to confirm even though it works.
This might be because of the confirmation logic in the RPC client, which looks for the provided blockhash:
https://github.com/anza-xyz/agave/blob/b46c87ea538a1508ed4ae36f8dbf6c75dd57c883/rpc-client/src/nonblocking/rpc_client.rs#L1090
Summary of changes
Specify a default transaction confirmation timeout.