token-client: Check simulation results for error #7523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem If the simulation for compute unit limit fails in the token-cli, it may continue to try to broadcast a transaction since the error falls through. Although that transaction should fail too, at least we don't run the risk of broadcasting something known to be bad. #### Summary of changes Add an `err()` function on the simulation results, and abort if the simulation for compute units fails.
github-actions
bot
added
the
stale
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the simulation for compute unit limit fails in the token-cli, it may continue to try to broadcast a transaction since the error falls through. Although that transaction should fail too, at least we don't run the risk of broadcasting something known to be bad.
Summary of changes
Add an
err()function on the simulation results, and abort if the simulation for compute units fails.