Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memo: Remove local program / client and point to new repo #7535

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

joncinque
Copy link
Contributor

Problem

The memo program and clients now live at their own repo, but the code still exists in the SPL repo.

Summary of changes

  • Update documentation for the memo program's new home
  • Remove program directory, update Rust dependencies to crates.io version
  • Remove JS bindings
  • Remove CI files

@joncinque joncinque requested a review from febo November 26, 2024 21:07
@joncinque joncinque changed the title memo: Remove local programs and point to new repo memo: Remove local program / client and point to new repo Nov 26, 2024
@joncinque
Copy link
Contributor Author

NOTE: We need to remove the downstream job from the monorepo before merging this

joncinque added a commit to joncinque/solana that referenced this pull request Nov 26, 2024
#### Problem

The SPL programs are in the process of being moved to program-specific
repos. Memo now exists in https://github.com/solana-program/memo, and
there's a PR to remove it from SPL at
solana-labs/solana-program-library#7535. If we
merge that, however, the downstream jobs will immediately fail.

#### Summary of changes

Remove all references to the memo program in downstream CI.
joncinque added a commit to anza-xyz/agave that referenced this pull request Nov 27, 2024
#### Problem

The SPL programs are in the process of being moved to program-specific
repos. Memo now exists in https://github.com/solana-program/memo, and
there's a PR to remove it from SPL at
solana-labs/solana-program-library#7535. If we
merge that, however, the downstream jobs will immediately fail.

#### Summary of changes

Remove all references to the memo program in downstream CI.
#### Problem

The memo program and clients now live at their own repo, but the code
still exists in the SPL repo.

#### Summary of changes

* Update documentation for the memo program's new home
* Remove program directory, update Rust dependencies to crates.io version
* Remove JS bindings
* Remove CI files
@joncinque
Copy link
Contributor Author

This is ready to go anytime!

Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@joncinque joncinque merged commit d544111 into solana-labs:master Dec 2, 2024
56 checks passed
@joncinque joncinque deleted the nomemo branch December 2, 2024 14:50
mergify bot pushed a commit to anza-xyz/agave that referenced this pull request Dec 2, 2024
#### Problem

The SPL programs are in the process of being moved to program-specific
repos. Memo now exists in https://github.com/solana-program/memo, and
there's a PR to remove it from SPL at
solana-labs/solana-program-library#7535. If we
merge that, however, the downstream jobs will immediately fail.

#### Summary of changes

Remove all references to the memo program in downstream CI.

(cherry picked from commit 4bdea46)
joncinque added a commit to anza-xyz/agave that referenced this pull request Dec 4, 2024
#### Problem

The SPL programs are in the process of being moved to program-specific
repos. Memo now exists in https://github.com/solana-program/memo, and
there's a PR to remove it from SPL at
solana-labs/solana-program-library#7535. If we
merge that, however, the downstream jobs will immediately fail.

#### Summary of changes

Remove all references to the memo program in downstream CI.

(cherry picked from commit 4bdea46)
joncinque added a commit to anza-xyz/agave that referenced this pull request Dec 5, 2024
#### Problem

The SPL programs are in the process of being moved to program-specific
repos. Memo now exists in https://github.com/solana-program/memo, and
there's a PR to remove it from SPL at
solana-labs/solana-program-library#7535. If we
merge that, however, the downstream jobs will immediately fail.

#### Summary of changes

Remove all references to the memo program in downstream CI.

(cherry picked from commit 4bdea46)
joncinque added a commit to anza-xyz/agave that referenced this pull request Dec 5, 2024
…#3865)

CI: Remove memo program from downstream job (#3804)

#### Problem

The SPL programs are in the process of being moved to program-specific
repos. Memo now exists in https://github.com/solana-program/memo, and
there's a PR to remove it from SPL at
solana-labs/solana-program-library#7535. If we
merge that, however, the downstream jobs will immediately fail.

#### Summary of changes

Remove all references to the memo program in downstream CI.

(cherry picked from commit 4bdea46)

Co-authored-by: Jon C <me@jonc.dev>
KirillLykov pushed a commit to anza-xyz/agave that referenced this pull request Dec 9, 2024
…#3865)

CI: Remove memo program from downstream job (#3804)

#### Problem

The SPL programs are in the process of being moved to program-specific
repos. Memo now exists in https://github.com/solana-program/memo, and
there's a PR to remove it from SPL at
solana-labs/solana-program-library#7535. If we
merge that, however, the downstream jobs will immediately fail.

#### Summary of changes

Remove all references to the memo program in downstream CI.

(cherry picked from commit 4bdea46)

Co-authored-by: Jon C <me@jonc.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants