-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memo: Remove local program / client and point to new repo #7535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
changed the title
memo: Remove local programs and point to new repo
memo: Remove local program / client and point to new repo
Nov 26, 2024
NOTE: We need to remove the downstream job from the monorepo before merging this |
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Nov 26, 2024
#### Problem The SPL programs are in the process of being moved to program-specific repos. Memo now exists in https://github.com/solana-program/memo, and there's a PR to remove it from SPL at solana-labs/solana-program-library#7535. If we merge that, however, the downstream jobs will immediately fail. #### Summary of changes Remove all references to the memo program in downstream CI.
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Nov 27, 2024
#### Problem The SPL programs are in the process of being moved to program-specific repos. Memo now exists in https://github.com/solana-program/memo, and there's a PR to remove it from SPL at solana-labs/solana-program-library#7535. If we merge that, however, the downstream jobs will immediately fail. #### Summary of changes Remove all references to the memo program in downstream CI.
#### Problem The memo program and clients now live at their own repo, but the code still exists in the SPL repo. #### Summary of changes * Update documentation for the memo program's new home * Remove program directory, update Rust dependencies to crates.io version * Remove JS bindings * Remove CI files
This is ready to go anytime! |
febo
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Dec 2, 2024
#### Problem The SPL programs are in the process of being moved to program-specific repos. Memo now exists in https://github.com/solana-program/memo, and there's a PR to remove it from SPL at solana-labs/solana-program-library#7535. If we merge that, however, the downstream jobs will immediately fail. #### Summary of changes Remove all references to the memo program in downstream CI. (cherry picked from commit 4bdea46)
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Dec 4, 2024
#### Problem The SPL programs are in the process of being moved to program-specific repos. Memo now exists in https://github.com/solana-program/memo, and there's a PR to remove it from SPL at solana-labs/solana-program-library#7535. If we merge that, however, the downstream jobs will immediately fail. #### Summary of changes Remove all references to the memo program in downstream CI. (cherry picked from commit 4bdea46)
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Dec 5, 2024
#### Problem The SPL programs are in the process of being moved to program-specific repos. Memo now exists in https://github.com/solana-program/memo, and there's a PR to remove it from SPL at solana-labs/solana-program-library#7535. If we merge that, however, the downstream jobs will immediately fail. #### Summary of changes Remove all references to the memo program in downstream CI. (cherry picked from commit 4bdea46)
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Dec 5, 2024
…#3865) CI: Remove memo program from downstream job (#3804) #### Problem The SPL programs are in the process of being moved to program-specific repos. Memo now exists in https://github.com/solana-program/memo, and there's a PR to remove it from SPL at solana-labs/solana-program-library#7535. If we merge that, however, the downstream jobs will immediately fail. #### Summary of changes Remove all references to the memo program in downstream CI. (cherry picked from commit 4bdea46) Co-authored-by: Jon C <me@jonc.dev>
KirillLykov
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Dec 9, 2024
…#3865) CI: Remove memo program from downstream job (#3804) #### Problem The SPL programs are in the process of being moved to program-specific repos. Memo now exists in https://github.com/solana-program/memo, and there's a PR to remove it from SPL at solana-labs/solana-program-library#7535. If we merge that, however, the downstream jobs will immediately fail. #### Summary of changes Remove all references to the memo program in downstream CI. (cherry picked from commit 4bdea46) Co-authored-by: Jon C <me@jonc.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The memo program and clients now live at their own repo, but the code still exists in the SPL repo.
Summary of changes