Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added blockheight to BlockResponse and VersionedBlockResponse #3625

Closed
wants to merge 3 commits into from
Closed

added blockheight to BlockResponse and VersionedBlockResponse #3625

wants to merge 3 commits into from

Conversation

shivaji43
Copy link
Contributor

@shivaji43 shivaji43 commented Nov 25, 2024 •
edited
Loading

Screenshot 2024-11-25 172002
Screenshot 2024-11-25 172045
Screenshot 2024-11-25 172100

added blockheight to BlockResponse and VersionedBlockResponse
linted and tested , the error is now gone because the property is added in the return type , solving #1969

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d7730cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Nov 25, 2024
@mergify mergify bot requested a review from a team November 25, 2024 13:06
@shivaji43
Copy link
Contributor Author

@steveluscher please take a look

steveluscher
steveluscher requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will not cause the library to throw if the RPC sends a blockHeight that is neither null, nor undefined, nor number. You have to also implement the superstruct validations, just like you did in #3592.

@shivaji43 shivaji43 closed this Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher requested changes

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivaji43 @steveluscher