This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Update to Agave test validator 2.0.x #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ee7988e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonFiles updated (6)
Unchanged files (119)
Total files change -319B -0.09% Final result: ✅ View report in BundleMon website ➡️ |
|
A preview of the GitHub Pages site based on this PR is now available here: |
steveluscher
force-pushed
the
11-27-test_validator_installer_now_sources_from_version_2.0.x_line
branch
6 times, most recently
from
43f1938 to
6c59ac1
Compare
steveluscher
changed the title
steveluscher
force-pushed
the
11-27-test_validator_installer_now_sources_from_version_2.0.x_line
branch
2 times, most recently
from
43caded to
88a885f
Compare
steveluscher
force-pushed
the
11-27-test_validator_installer_now_sources_from_version_2.0.x_line
branch
from
88a885f to
ee7988e
Compare
steveluscher
commented
Nov 28, 2024
| @@ -2074,7 +2074,7 @@ describe('getProgramAccounts', () => { | |||
| rentEpoch: expect.any(BigInt), | |||
| space: 8n, | |||
| }, | |||
| pubkey: 'SysvarFees111111111111111111111111111111111', | |||
There was a problem hiding this comment.
This sysvar is gone.
Comment on lines
+368
to
+371
| replacementBlockhash: { | ||
| blockhash: expect.any(String), | ||
| lastValidBlockHeight: expect.any(BigInt), | ||
| }, |
There was a problem hiding this comment.
See also #2869.
Comment on lines
-19
to
-20
| export const SYSVAR_FEES_ADDRESS = | ||
| 'SysvarFees111111111111111111111111111111111' as Address<'SysvarFees111111111111111111111111111111111'>; |
There was a problem hiding this comment.
This sysvar is fetchable using the test validator in Agave 1.18.
% curl http://localhost:8899 -X POST -H "Content-Type: application/json" -d '{"jsonrpc":"2.0","id":"LOL","method":"getAccountInfo","params":["SysvarFees111111111111111111111111111111111"]}'
{"jsonrpc":"2.0","result":{"context":{"apiVersion":"1.18.26","slot":64},"value":{"data":"11111111","executable":false,"lamports":946560,"owner":"Sysvar1111111111111111111111111111111111111","rentEpoch":0,"space":8}},"id":"LOL"}…but appears to have been removed from the test validator in Agave 2.0.
% curl http://localhost:8899 -X POST -H "Content-Type: application/json" -d '{"jsonrpc":"2.0","id":"LOL","method":"getAccountInfo","params":["SysvarFees111111111111111111111111111111111"]}'
{"jsonrpc":"2.0","result":{"context":{"apiVersion":"2.0.17","slot":0},"value":null},"id":"LOL"}Note that you can still fetch this account on mainnet-beta, even against a 2.0 RPC.
What's the right thing to do here? Should we leave it in the @solana/sysvars package, mark it as deprecated, set the tests as ‘supposed to fail’, and leave it, or should we do what I did here and delete it completely before anyone much starts to rely on it in [email protected]?
There was a problem hiding this comment.
Possibly anza-xyz/agave#2003?
steveluscher
deleted the
11-27-test_validator_installer_now_sources_from_version_2.0.x_line
branch
Closed
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.