Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add zk token proof program description #32011
[docs] Add zk token proof program description #32011
Changes from 6 commits
19f2dbe
e0796fd
fbfe681
b1518aa
4256ff9
608d980
852c213
4df823f
334e0c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to call out SPL Token 2022 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, yeah I guess it is not necessary.
In general, I mention Token 2022 in the doc because:
Here, I was intending the effect of (2), but perhaps we can remove the Token 2022 in this sentence and then we can mention to refer to Token 2022 for examples on how proof program can be used somewhere in the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I removed mentioning of Token 2022 here. I had a couple of applications like these solana-labs/solana-program-library#3984 in mind that would need to use the proof program. Perhaps we can update doc with pointers to examples that include Token-2022 and some of these applications once they are complete.