Fix ProgramTestContext::set_account not updating programs

[andreisilviudragnea]

Problem

ProgramTestContext::warp_to_slot ignores ProgramTestContext::set_account program updates.

Summary of Changes

This PR tries to fix this problem by using BankForks::insert_from_ledger (introduced in #31331) instead of BankForks::insert everywhere inside ProgramTestContext. From my investigations, ProgramTestContext::set_account was never able to update program accounts, not even before #31331.

I also added relevant unit tests which verify the bug fix. I did not know how to write them without using precompiled Solana programs. The 3 precompiled Solana programs are variations of the program from here.

Fixes #34728

[andreisilviudragnea]

@pgarg66 @Lichtso I pinged you because you are the author and reviewer of #31331.

[andreisilviudragnea]

@tiago18c Please have a look at this PR, updating program accounts never worked for me before.

[buffalojoec]

@andreisilviudragnea I might be missing something here, but have you tried ProgramTest::add_program(..)? Or do you specifically need to add this program using the context post-warp?

I've run into a similar issue before when trying to add an upgradeable program using ProgramTestContext::add_account(..) to add both the program and program data accounts, where the program was stuck at LoadedProgramType::DelayVisibility in the program runtime.

ProgramTest::add_program(..) specifically adds it using one single program account under the BpfLoader, which seems to shake the delayed visibility issue.

[andreisilviudragnea]

@buffalojoec I am trying to re-use the same ProgramTestContext with multiple versions of the same Solana program.

I want to be able to simulate Solana transactions on multiple versions of the same program as part of a Tokio web app. And it's not clear to me if ProgramTestContext can be cheaply created and destroyed for each transaction simulation request, so I want to re-use an existing ProgramTestContext where I update the program account to a new version.

[buffalojoec]

@buffalojoec I am trying to re-use the same ProgramTestContext with multiple versions of the same Solana program.

I want to be able to simulate Solana transactions on multiple versions of the same program as part of a Tokio web app. And it's not clear to me if ProgramTestContext can be cheaply created and destroyed for each transaction simulation request, so I want to re-use an existing ProgramTestContext where I update the program account to a new version.

I would say unless you specifically need to test the program in state A, then do an upgrade, then test it in state B, all within the same blockstore, then you should use separate ProgramTestContext instances.

I can't advise exactly how cheap they are to spin up, but we do this with all of SPL. Here's some examples.

You can see in each test (here, here, and the rest), we're spinning up a new ProgramTestContext using this function here.

In your case, you'd just add a different program processor with add_program(..) on each ProgramTest initialization.

[Lichtso]

As explained in #34728 (comment), you have to use the deployment instruction like this test does:

solana/programs/sbf/tests/programs.rs

Line 1724 in 8869d0c

fn test_program_sbf_upgrade() {

That ProgramTestContext::set_account() was ever able to upgrade a program was not intended and got removed in v1.16.