Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Impl: cost model uses number of requested write locks #34820

Merged

Conversation

apfitzge
Copy link
Contributor

Problem

Implementation of #34819

Summary of Changes

  • Some write-locks are demoted to read-locks during transaction sanitization
  • Change the cost model to apply write lock costs for the number of requested write locks, instead of the number of write-locks after demotion
  • Requires feature-gate so that activation of 2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj (
    Feature Gate: Validator applies cost tracker to blocks during replay #29595) will not cause this change to break consensus

Fixes #

@apfitzge apfitzge force-pushed the feature-cost-requested-write-locks branch 2 times, most recently from d7f029a to 544a992 Compare January 18, 2024 00:24
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (9d13244) 81.7% compared to head (4ea6629) 81.7%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34820     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         826      826             
  Lines      223114   223205     +91     
=========================================
+ Hits       182335   182399     +64     
- Misses      40779    40806     +27     

@apfitzge apfitzge marked this pull request as ready for review January 18, 2024 18:16
@apfitzge apfitzge requested a review from tao-stones January 18, 2024 18:16
tao-stones
tao-stones previously approved these changes Jan 18, 2024
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge
Copy link
Contributor Author

@taozhu-chicago sorry had to rebase because of conflict in adding features to feature-set

Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit 5e4332e into solana-labs:master Jan 22, 2024
45 checks passed
@apfitzge apfitzge deleted the feature-cost-requested-write-locks branch January 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants