Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: throttle queued CUs #34890

Closed

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Jan 22, 2024

Problem

  • In some cases, scheduler queues too much work too early.

Summary of Changes

  • Only continue scheduling up to 12M outstanding CUs per thread.

Blocked by #34881
Fixes #

@apfitzge
Copy link
Contributor Author

THIS IS CURRENTLY EXPERIMENTAL - #34888 should encourage more accurate requested CUs - we probably need to wait for that to be rolled out for a while before doing this. Requested CUs are significantly higher than actual usage, meaning the load-balancing would potentially be made worse!

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a5c470d) 81.7% compared to head (6b61650) 81.7%.
Report is 214 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34890     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         826      826             
  Lines      223413   223453     +40     
=========================================
+ Hits       182614   182625     +11     
- Misses      40799    40828     +29     

@github-actions github-actions bot added stale [bot only] Added to stale content; results in auto-close after a week. and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Feb 6, 2024
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Feb 21, 2024
@github-actions github-actions bot closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
Development

Successfully merging this pull request may close these issues.

1 participant