-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fee_details to fee calculation #35021
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35021 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 834 830 -4
Lines 224803 224838 +35
=======================================
+ Hits 183467 183504 +37
+ Misses 41336 41334 -2 |
27e15a4
to
637be2f
Compare
637be2f
to
fbd3e82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks for introducing the feature for removing the rounding!
* add fee_details to fee calculation * fix - no need to round after summing u64 * feature gate on removing unwanted rounding
Problem
To reward priority fee differently from transaction fee (solana-foundation/solana-improvement-documents#96), priority fee and transaction fee should be separately identified from result of
calculate_fee(...)
Summary of Changes
struct FeeDetails {}
calculate_fee_details(...) -> FeeDetails
calculate_fee(...) -> u64
without changing its logic to minimize impact on call sitesFeature Gate Issue: #34982