Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Removes cap_accounts_data_len feature #35378

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Feb 29, 2024

Problem

The cap_accounts_data_len feature cannot and will not ever be activated. The code has been removed, but before that, it would introduce potential non-determinism. For more information, please refer to #27029

Here's the original feature gate issue: #24135

Now all that remains is the feature itself, and can be safely removed.

PRs that removed code gated by this feature:

Summary of Changes

Remove the cap_accounts_data_len feature

Feature Gate Issue: #24135

@brooksprumo brooksprumo self-assigned this Feb 29, 2024
@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label Feb 29, 2024
@brooksprumo brooksprumo marked this pull request as ready for review February 29, 2024 20:43
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (6ee3bb9) to head (b79f15f).
Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #35378    +/-   ##
========================================
  Coverage    81.7%    81.7%            
========================================
  Files         834      834            
  Lines      224299   224814   +515     
========================================
+ Hits       183361   183865   +504     
- Misses      40938    40949    +11     

@jeffwashington jeffwashington requested review from CriesofCarrots and removed request for jeffwashington March 1, 2024 15:36
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Could you please add to the PR description a link to the PR(s) that removed the code gated by this feature? I assume it's linked to the Feature Gate issue, but it is hard to tell which it might be.

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ tyera's pr/issue linkage suggestions

@brooksprumo brooksprumo merged commit 6729432 into solana-labs:master Mar 1, 2024
46 checks passed
@brooksprumo brooksprumo deleted the accounts-data-size/remove-cap-total branch March 1, 2024 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants