Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments clarifying non-emptiness of threadset #35388

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Comments clarifying non-emptiness of threadset #35388

merged 1 commit into from
Mar 1, 2024

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Mar 1, 2024

Problem

#35368 was reported. The code is fine, but clarifying comments are helpful here.

Summary of Changes

  • Add comment on ThreadAwareAccountLocks::try_lock_accounts to clarify it will never call thread_selector with a non-empty thread-set.
  • Add comment on PrioGraphScheduler::select_thread to clarify it will never be called with a non-empty set.

Fixes #35368

@apfitzge apfitzge mentioned this pull request Mar 1, 2024
Closed
tao-stones
tao-stones approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit ede9163 into solana-labs:master Mar 1, 2024
35 checks passed
@apfitzge apfitzge deleted the 35368 branch March 1, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible Incompleteness
2 participants
@apfitzge @tao-stones