remove the dependency on the blake3 "digest" feature #35701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solana already depends on the "traits-preview" feature, which is [the intended way](https://github.com/BLAKE3-team/BLAKE3/blob/1170f023bf459ea3d0bedd285d6ae32309ee348c/Cargo.toml#L52) to activate the optional dependency on `digest`. Version 1.5.2 of the `blake3` crate started using the new-ish `dep:` notation in `Cargo.toml`, which removes the unintended "digest" feature. Solana currently pins v1.5.0, but this will be a build break when that pin is updated. I think a user has already run into this here: https://solana.stackexchange.com/q/17787/29050.
anza-team
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Thank you for the contribution! This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave
|
(I have release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solana already depends on the "traits-preview" feature, which is the intended way to activate the optional dependency on
digest. Version 1.5.2 of theblake3crate started using the new-ishdep:notation inCargo.toml, which removes the unintended "digest" feature. Solana currently pins v1.5.0, but this will be a build break when that pin is updated. I think a user has already run into this here: https://solana.stackexchange.com/q/17787/29050.