feat: you can now configure the SolanaMobileWalletAdapter with an address selector
#171
Conversation
| // TODO(#44): support multiple addresses | ||
| this._authorizationResult.addresses[0], | ||
| ); | ||
| this._publicKey = getPublicKeyFromAddress(this._selectedAddress); |
There was a problem hiding this comment.
I might be missing something here, but how can you reliably get a public key from an address? Addresses (if not on Solana) may not be reversible to pubkeys.
There was a problem hiding this comment.
I guess I presumed that the Solana wallet-adapter would only ever work with Solana wallets. We’d have to change the return type of useWallet, which right now only has the concept of publicKey.
There was a problem hiding this comment.
Ah, that's a fair assumption then! I think I was not seeing that the context of this code is wallet-adapter-mobile and not mobile-wallet-adapter
| @@ -29,6 +24,10 @@ export interface AuthorizationResultCache { | |||
| set(authorizationResult: AuthorizationResult): Promise<void>; | |||
| } | |||
|
|
|||
| export interface AddressSelector { | |||
| select(addresses: AuthorizationResult['addresses']): Promise<AuthorizationResult['addresses'][number]>; | |||
There was a problem hiding this comment.
Maybe a stylistic choice since the resolved type will be the same, but AuthorizationResult['addresses'], and definitely AuthorizationResult['addresses'][number], are less clear than their Base64EncodedAddress[] / Base64EncodedAddress counterparts.
There was a problem hiding this comment.
Good question. I think there are two positions you can take here:
- This is a thing that turns
T[]intoT - This is a thing that takes
ThisParticularType[]and turns it intoThisParticularType
My goal with making it a lookup on addresses was to make Typescript do more work for me; if the type changes then that change automatically flows through this function.
My implementation actually hits somewhere in between option 1 and 2, and maybe I should go for option 1 which just says ‘I’m going to give you a list of who knows what and you give me a single item back.’
There was a problem hiding this comment.
Oh, you like writing Java? Name every AsyncSelector { select<T>(items: T[]): Promise<T> }
There was a problem hiding this comment.
I like not writing types at all and making Typescript work for the money I spent on it.
Uh… wait.
Background
Mobile wallet adapter allows us to authorize multiple addresses from a single click of the ‘connect’ button. This causes an impedance mismatch between MWA and
@solana/wallet-adapterthat doesn't have the concept of multiple addresses.Problem statement
The existing
wallet-adapterAPI is single-key, like this:How, in this world, should
wallet-adaptermake the choice ofpublicKey, if the user decides to authorize multiple addresses in a mobile wallet adapter session?Summary of changes
SolanaMobileWalletAdaptercalledaddressSelector. Developers can provide an implementation of this to make a sensible selection of address given multiple addresses.createDefaultAddressSelectorhelper, that just chooses the first address in the list.Note, that because the selector is async, app developers have a great amount of freedom to pause execution of the wallet adapter plugin to show – for instance – an address selection UI to their users.
Addresses #44.