Walletlib: Multi Account Auth Repo #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelsulistio
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
For my own understanding, summarizing the changes:
- Add the
parentIdfield to an Account - Add DB migration code for version 5/6
- Add multi account to AuthRepo
- Add multi account API to onComplete methods
Changes look good and make sense to me from a high level.Thorough testing with an example app would help reveal any issues.
| @Nullable String[] chains, @Nullable String[] features); | ||
|
|
||
| // @Nullable | ||
| // List<AccountRecord> query(int parentId); |
There was a problem hiding this comment.
intentionally commented out?
| // migrate to multi account structure | ||
| Log.w(TAG, "Old database schema detected; pre-v2.1.0, migrating to multi account structure"); | ||
|
|
||
| // try (final Cursor cursor = db.rawQuery("SELECT " + |
There was a problem hiding this comment.
Intentionally left commented?
| /* package */ class AccountRecord { | ||
| @IntRange(from = 1) | ||
| final int id; | ||
|
|
||
| @IntRange(from = 1) | ||
| final int parentId; |
There was a problem hiding this comment.
To clarify, the parentId of an account will always be the id of the "authRecord" that the account is associated with, correct?
Curios, why its called parentId instead of authRecordId? Is there another possible value it can be?
There was a problem hiding this comment.
to align with the schema. Parent id is used to indicate that this is a subtable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses what should be the final refactor update to support multi-account through the entire MWA SDK stack. (#44 & #438)
The walletlib sdk authentication repository has been updated to support multiple authorized accounts (publickeys) per AuthRecord. The rest of the SDK stack was previously updated to support a list of accounts for each auth request.
Note: sample apps still need to be updated to demonstrate the use of multiple accounts in a session