Handle error properly on file close

solarwinds · Jul 30, 2024 · fae6657 · fae6657
1 parent e5de4ad
commit fae6657
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/internal/host/k8s/k8s.go b/internal/host/k8s/k8s.go
@@ -169,10 +169,14 @@ func getPodUidFromFile(fn string) (string, error) {
 
 func getPodUidFromProc(fn string) (string, error) {
 	f, err := os.Open(fn)
-	defer f.Close()
 	if err != nil {
 		return "", err
 	}
+	defer func() {
+		if err := f.Close(); err != nil {
+			log.Warningf("Could not close file: %s", err)
+		}
+	}()
 	scanner := bufio.NewScanner(f)
 	for scanner.Scan() {
 		line := scanner.Text()