Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hardcoded default collector #42

Merged
merged 1 commit into from
Nov 28, 2023
Merged

update hardcoded default collector #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const (
// max config file size = 1MB
maxConfigFileSize = 1024 * 1024
// the default collector url
defaultSSLCollector = "apm.collector.cloud.solarwinds.com:443"
defaultSSLCollector = "apm.collector.na-01.cloud.solarwinds.com:443"
maxTokenBucketCapacity = 8
maxTokenBucketRate = 4
)
Expand Down Expand Up @@ -85,7 +85,7 @@ type Config struct {
sync.RWMutex `yaml:"-"`

// Collector defines the host and port of the SolarWinds Observability collector
Collector string `yaml:"Collector,omitempty" env:"SW_APM_COLLECTOR" default:"apm.collector.cloud.solarwinds.com:443"`
Collector string `yaml:"Collector,omitempty" env:"SW_APM_COLLECTOR" default:"apm.collector.na-01.cloud.solarwinds.com:443"`

// ServiceKey defines the service key and service name
ServiceKey string `yaml:"ServiceKey,omitempty" env:"SW_APM_SERVICE_KEY"`
Expand Down
2 changes: 1 addition & 1 deletion internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func TestPrintDelta(t *testing.T) {
changed.ReporterProperties.EventFlushInterval = 100

assert.Equal(t,
` - Collector (SW_APM_COLLECTOR) = test.com:443 (default: apm.collector.cloud.solarwinds.com:443)
` - Collector (SW_APM_COLLECTOR) = test.com:443 (default: apm.collector.na-01.cloud.solarwinds.com:443)
- PrependDomain (SW_APM_PREPEND_DOMAIN) = true (default: false)
- ReporterProperties.EventFlushInterval (SW_APM_EVENTS_FLUSH_INTERVAL) = 100 (default: 2)`,
getDelta(newConfig().reset(), changed, "").sanitize().String())
Expand Down
Loading