Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle entryType when storing/updating observation units #4628

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Handle entryType when storing/updating observation units #4628

merged 2 commits into from
Oct 13, 2023

Conversation

timparsons
Copy link
Contributor

Description

Updated the BrAPI code to process the entryType field when storing/updating ObservationUnits

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

MFlores2021
MFlores2021 reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@MFlores2021 MFlores2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Will approve when test pass

darekbienkowski
darekbienkowski approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@darekbienkowski darekbienkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;-)

@darekbienkowski darekbienkowski removed the request for review from Sri-2023 October 12, 2023 16:00
@lukasmueller lukasmueller merged commit baf6dce into master Oct 13, 2023
1 check passed
@lukasmueller lukasmueller deleted the topic/BI-1815 branch October 13, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFlores2021 MFlores2021 MFlores2021 approved these changes

@darekbienkowski darekbienkowski darekbienkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timparsons @darekbienkowski @MFlores2021 @lukasmueller