Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phenotype Upload: additional acceptable column headers #4765

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

dwaring87
Copy link
Member

Description

This PR allows the first column of the "simple" phenotype upload to be one of any:

  • observationunit_name
  • plot_name
  • subplot_name
  • plant_name
  • observationUnitName
  • plotName
  • sublotName
  • plantName

We frequently have some users trying to upload data with 'plot_name' or copying the column from some of the downloads on the website, which may use 'observationUnitName'. The upload will accept any of these as a valid first column header.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

allow alternate column header for first column: observationunit_name, plot_name, observationUnitName, plotName
@lukasmueller
Copy link
Member

Should some documentation also be changed for that?

Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some documentation about the format also needs to be updated?

Add additional acceptable column headers to the description for the simple format's first column
@dwaring87
Copy link
Member Author

dwaring87 commented Jan 9, 2024

@lukasmueller I added the other acceptable column headers to the spreadsheet format info.

Copy link
Member

@bellerbrock bellerbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lukasmueller lukasmueller merged commit 2d8b0eb into master Jan 23, 2024
1 check passed
@lukasmueller lukasmueller deleted the topic/trait_upload_column_headers branch January 23, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants