Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back generic_message func, removed accidentally #4775

Merged
merged 3 commits into from
Jan 8, 2024
Merged

bring back generic_message func, removed accidentally #4775

merged 3 commits into from
Jan 8, 2024

Conversation

isaak
Copy link
Member

@isaak isaak commented Jan 3, 2024

Description

-- bring back generic_message func, was removed accidentally.
-- fixes private analysis results display breakage when user is not logged in.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

lukasmueller
lukasmueller approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

alockrow
alockrow approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@alockrow alockrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit 6ed902c into master Jan 8, 2024
1 check passed
@lukasmueller lukasmueller deleted the topic/solgs/add-generic_message-func branch January 8, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alockrow alockrow alockrow approved these changes

@lukasmueller lukasmueller lukasmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaak @lukasmueller @alockrow