Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Locus and Locus_Alleles list type #5200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ClayBirkett
Copy link
Member

@ClayBirkett ClayBirkett commented Nov 13, 2024

Add locus and locus_alleles list type
MarkerSet should use list type of locus_alleles

#5198

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • [x ] New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@ryan-preble ryan-preble self-requested a review November 13, 2024 15:58
@lukasmueller lukasmueller self-requested a review November 14, 2024 16:03
@ryan-preble
Copy link
Contributor

Should the DB patch remove the locus_ids list type in addition to adding the locus list type? As far as I can tell this will result in users being able to make lists of locus_ids, locus, and locus_alleles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants