Merge pull request #27 from solidify/bugs/missing-jira-user

Adding check for jira email when mapping user. #26
solidify · Feb 8, 2019 · 35109e3 · 35109e3
2 parents 8fb9fcf + 43d2928
commit 35109e3
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 8 deletions.
diff --git a/src/WorkItemMigrator/JiraExport/JiraProvider.cs b/src/WorkItemMigrator/JiraExport/JiraProvider.cs
@@ -266,13 +266,28 @@ public int GetNumberOfComments(string key)
         public string GetUserEmail(string username)
         {
             if (_userEmailCache.TryGetValue(username, out string email))
+            {
                 return email;
+            }
             else
             {
-                var user = Jira.Users.GetUserAsync(username).Result;
-                email = user.Email;
-                _userEmailCache.Add(username, email);
-                return email;
+                try
+                {
+                    var user = Jira.Users.GetUserAsync(username).Result;
+                    if(string.IsNullOrEmpty(user.Email))
+                    {
+                        Logger.Log(LogLevel.Warning, $"Email for user '{username}' not found in Jira, using '{username}' for mapping.");
+                        return username;
+                    }
+                    email = user.Email;
+                    _userEmailCache.Add(username, email);
+                    return email;
+                }
+                catch(Exception e)
+                {
+                    Logger.Log(LogLevel.Warning, $"User '{username}' not found in Jira, using '{username}' for mapping.");
+                    return username;
+                }
             }
         }
 

diff --git a/src/WorkItemMigrator/Migration.Common/Logger.cs b/src/WorkItemMigrator/Migration.Common/Logger.cs
@@ -130,15 +130,21 @@ public static void Summary()
             {
                 Console.WriteLine("::: SUMMARY :::");
                 Console.WriteLine("===============");
-                foreach (var warning in Warnings)
+                if(Warnings.Count > 0)
                 {
                     Console.WriteLine("Warnings:");
-                    LogInternal(LogLevel.Warning, warning);
+                    foreach (var warning in Warnings)
+                    {
+                        LogInternal(LogLevel.Warning, warning);
+                    }
                 }
-                foreach (var error in Errors)
+                if (Errors.Count > 0)
                 {
                     Console.WriteLine("Errors:");
-                    LogInternal(LogLevel.Error, error);
+                    foreach (var error in Errors)
+                    {
+                        LogInternal(LogLevel.Error, error);
+                    }
                 }
             }
         }