NotFor matches should still depend on Target Field name. #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Hjelm
changed the base branch from
master
to
feature/file-not-found-logic
Alexander-Hjelm
merged commit 341ff19
into
solidify:feature/file-not-found-logic
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the logic of
FieldMapperUtils.MapValue. The second leg of the if-statement that deals withNotForconditions does not enforce the matching of the Target Field name.I've also added some more unit tests, including
MapValue_WithMatchesNotForButTargetDoesNotMatch_ReturnsFalseAndNull()which exposes this particular bug.