Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update createResource, add "state" field. #918

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

klequis
Copy link
Contributor

@klequis klequis commented Oct 10, 2024

The new state field was documented but not added to the signature.

  • [ x] I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

The doc states that a new state field had been added but it did not appear in the createResource signature.

Related issues & labels

  • Closes #
  • Suggested label(s) (optional):

The new state field was documented but not added to the signature.
Copy link

stackblitz bot commented Oct 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 802fb04
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67453958433cde000820de1f
😎 Deploy Preview https://deploy-preview-918--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Someone might want to confirm that "state" belongs in all of the examples vs just some of them. I put it in 4 examples/instances of `createResource`.
@klequis
Copy link
Contributor Author

klequis commented Oct 10, 2024

Someone might want to confirm that "state" belongs in all of the examples vs just some of them. I put it in 4 examples/instances of createResource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant