Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSdoc #495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add JSdoc #495

wants to merge 2 commits into from

Conversation

marvin-j97
Copy link
Contributor

@marvin-j97 marvin-j97 commented Nov 8, 2024

As of now, the IDE experience with Solid Router is subpar because of missing JSdocs. I added JSdocs for most Router functions:

Before

image

After

image

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: d92290e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant