Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPTIONS to HTTP_METHODS Array #1683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christhornham
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

API routes often receive preflight OPTIONS requests. Currently, SolidStart does not have an OPTIONS method to deal with these request, making it very hard to manage CORS.

What is the new behavior?

Adding and OPTIONS method will allow developers to build an OPTIONS() method to specifically handle preflight requests inside API routes.

Other information

SolidStart is great :)

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 64e2b73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@christhornham christhornham changed the title Added OPTIONS to HTTP_METHODS Array Add OPTIONS to HTTP_METHODS Array Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant