Added php-cs-fixer rule void_return

solidtime-io · Sep 18, 2024 · bfd70f2 · bfd70f2
1 parent 590fed6
commit bfd70f2
Show file tree

Hide file tree

Showing 51 changed files with 96 additions and 95 deletions.
diff --git a/app/Actions/Fortify/CreateNewUser.php b/app/Actions/Fortify/CreateNewUser.php
@@ -82,7 +82,7 @@ public function create(array $input): User
         }
         $user = null;
         $organization = null;
-        DB::transaction(function () use (&$user, &$organization, $input, $timezone, $startOfWeek, $currency) {
+        DB::transaction(function () use (&$user, &$organization, $input, $timezone, $startOfWeek, $currency): void {
             $user = User::create([
                 'name' => $input['name'],
                 'email' => $input['email'],

diff --git a/app/Actions/Jetstream/AddOrganizationMember.php b/app/Actions/Jetstream/AddOrganizationMember.php
@@ -38,7 +38,7 @@ public function add(User $owner, Organization $organization, string $email, ?str
 
         AddingTeamMember::dispatch($organization, $newOrganizationMember);
 
-        DB::transaction(function () use ($organization, $newOrganizationMember, $role) {
+        DB::transaction(function () use ($organization, $newOrganizationMember, $role): void {
             $organization->users()->attach(
                 $newOrganizationMember, ['role' => $role]
             );
@@ -93,7 +93,7 @@ protected function rules(): array
      */
     protected function ensureUserIsNotAlreadyOnTeam(Organization $team, string $email): Closure
     {
-        return function ($validator) use ($team, $email) {
+        return function ($validator) use ($team, $email): void {
             $validator->errors()->addIf(
                 $team->hasRealUserWithEmail($email),
                 'email',

diff --git a/app/Console/Commands/TimeEntry/TimeEntrySendStillRunningMailsCommand.php b/app/Console/Commands/TimeEntry/TimeEntrySendStillRunningMailsCommand.php
@@ -54,7 +54,7 @@ public function handle(): int
                 $query->where('is_placeholder', '=', false);
             })
             ->orderBy('created_at', 'asc')
-            ->chunk(500, function (Collection $timeEntries) use ($dryRun, &$sentMails) {
+            ->chunk(500, function (Collection $timeEntries) use ($dryRun, &$sentMails): void {
                 /** @var Collection<int, TimeEntry> $timeEntries */
                 foreach ($timeEntries as $timeEntry) {
                     $user = $timeEntry->user;

diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php
@@ -27,7 +27,7 @@ class Handler extends ExceptionHandler
      */
     public function register(): void
     {
-        $this->reportable(function (Throwable $e) {
+        $this->reportable(function (Throwable $e): void {
             //
         });
     }

diff --git a/app/Filament/Resources/OrganizationResource.php b/app/Filament/Resources/OrganizationResource.php
@@ -122,7 +122,7 @@ public static function table(Table $table): Table
                                 ->persistent()
                                 ->send();
 
-                            return response()->streamDownload(function () use ($file) {
+                            return response()->streamDownload(function () use ($file): void {
                                 echo Storage::disk(config('filesystems.private'))->get($file);
                             }, 'export.zip');
                         } catch (\Exception $exception) {
@@ -137,7 +137,7 @@ public static function table(Table $table): Table
                     }),
                 Action::make('Import')
                     ->icon('heroicon-o-inbox-arrow-down')
-                    ->action(function (Organization $record, array $data) {
+                    ->action(function (Organization $record, array $data): void {
                         try {
                             $file = Storage::disk(config('filament.default_filesystem_disk'))->get($data['file']);
                             if ($file === null) {

diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
@@ -81,10 +81,10 @@ public function boot(): void
         });
 
         // Scramble
-        Scramble::extendOpenApi(function (OpenApi $openApi) {
+        Scramble::extendOpenApi(function (OpenApi $openApi): void {
             $openApi->secure(
                 SecurityScheme::oauth2()
-                    ->flow('authorizationCode', function (OAuthFlow $flow) {
+                    ->flow('authorizationCode', function (OAuthFlow $flow): void {
                         $flow
                             ->authorizationUrl('https://solidtime.test/oauth/authorize');
                     })

diff --git a/app/Providers/RouteServiceProvider.php b/app/Providers/RouteServiceProvider.php
@@ -37,9 +37,9 @@ public function boot(): void
                 : Limit::perMinute(60)->by($request->ip());
         });
 
-        $this->routes(function () {
+        $this->routes(function (): void {
             Route::middleware('health-check')
-                ->group(function () {
+                ->group(function (): void {
                     Route::get('health-check/up', [HealthCheckController::class, 'up']);
                     Route::get('health-check/debug', [HealthCheckController::class, 'debug']);
                 });

diff --git a/app/Service/BillableRateService.php b/app/Service/BillableRateService.php
@@ -28,9 +28,9 @@ public function updateTimeEntriesBillableRateForProject(Project $project): void
             ->where('billable', '=', true)
             ->where('organization_id', '=', $project->organization_id)
             ->whereBelongsTo($project, 'project')
-            ->whereDoesntHave('member', function (Builder $query) use ($project) {
+            ->whereDoesntHave('member', function (Builder $query) use ($project): void {
                 /** @var Builder<Member> $query */
-                $query->whereHas('projectMembers', function (Builder $query) use ($project) {
+                $query->whereHas('projectMembers', function (Builder $query) use ($project): void {
                     /** @var Builder<ProjectMember> $query */
                     $query->whereBelongsTo($project, 'project')
                         ->whereNotNull('billable_rate');
@@ -62,7 +62,7 @@ public function updateTimeEntriesBillableRateForOrganization(Organization $organ
         TimeEntry::query()
             ->where('billable', '=', true)
             ->where('organization_id', '=', $organization->getKey())
-            ->whereDoesntHave('member', function (Builder $builder) {
+            ->whereDoesntHave('member', function (Builder $builder): void {
                 /** @var Builder<Member> $builder */
                 $builder->whereNotNull('billable_rate');
             })

diff --git a/app/Service/DeletionService.php b/app/Service/DeletionService.php
@@ -35,7 +35,7 @@ public function __construct(UserService $userService, MemberService $memberServi
     public function deleteOrganization(Organization $organization, bool $inTransaction = true, ?User $ignoreUser = null): void
     {
         if ($inTransaction) {
-            DB::transaction(function () use ($organization) {
+            DB::transaction(function () use ($organization): void {
                 $this->deleteOrganization($organization, false);
             });
 
@@ -123,7 +123,7 @@ public function deleteOrganization(Organization $organization, bool $inTransacti
     public function deleteUser(User $user, bool $inTransaction = true): void
     {
         if ($inTransaction) {
-            DB::transaction(function () use ($user) {
+            DB::transaction(function () use ($user): void {
                 $this->deleteUser($user, false);
             });
 

diff --git a/app/Service/Import/ImportService.php b/app/Service/Import/ImportService.php
@@ -31,7 +31,7 @@ public function import(Organization $organization, string $importerType, string
         $lock = Cache::lock('import:'.$organization->getKey(), config('octane.max_execution_time', 60) + 1);
 
         if ($lock->get()) {
-            DB::transaction(function () use (&$importer, &$data, &$timezone) {
+            DB::transaction(function () use (&$importer, &$data, &$timezone): void {
                 $importer->importData($data, $timezone);
             });
             $lock->release();

diff --git a/app/Service/Import/Importers/DefaultImporter.php b/app/Service/Import/Importers/DefaultImporter.php
@@ -113,7 +113,7 @@ public function init(Organization $organization): void
                 'nullable',
                 'integer',
             ],
-        ], beforeSave: function (Project $project) {
+        ], beforeSave: function (Project $project): void {
             if ($project->billable_rate === 0) {
                 $project->billable_rate = null;
             }
@@ -126,7 +126,7 @@ public function init(Organization $organization): void
                 'nullable',
                 'integer',
             ],
-        ], beforeSave: function (ProjectMember $projectMember) {
+        ], beforeSave: function (ProjectMember $projectMember): void {
             if ($projectMember->billable_rate === 0) {
                 $projectMember->billable_rate = null;
             }

diff --git a/database/factories/MemberFactory.php b/database/factories/MemberFactory.php
@@ -85,7 +85,7 @@ public function withBillableRate(): self
 
     public function attachToOrganization(Organization $organization, array $pivot = []): static
     {
-        return $this->afterCreating(function (User $user) use ($organization, $pivot) {
+        return $this->afterCreating(function (User $user) use ($organization, $pivot): void {
             $user->organizations()->attach($organization, $pivot);
         });
     }

diff --git a/database/factories/UserFactory.php b/database/factories/UserFactory.php
@@ -82,7 +82,7 @@ public function unverified(): static
 
     public function attachToOrganization(Organization $organization, array $pivot = []): static
     {
-        return $this->afterCreating(function (User $user) use ($organization, $pivot) {
+        return $this->afterCreating(function (User $user) use ($organization, $pivot): void {
             $user->organizations()->attach($organization, $pivot);
         });
     }

diff --git a/database/migrations/2014_10_12_000000_create_users_table.php b/database/migrations/2014_10_12_000000_create_users_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('users', function (Blueprint $table) {
+        Schema::create('users', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->string('name');
             $table->string('email');

diff --git a/database/migrations/2014_10_12_100000_create_password_reset_tokens_table.php b/database/migrations/2014_10_12_100000_create_password_reset_tokens_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('password_reset_tokens', function (Blueprint $table) {
+        Schema::create('password_reset_tokens', function (Blueprint $table): void {
             $table->string('email')->primary();
             $table->string('token');
             $table->timestamp('created_at')->nullable();

diff --git a/database/migrations/2014_10_12_200000_add_two_factor_columns_to_users_table.php b/database/migrations/2014_10_12_200000_add_two_factor_columns_to_users_table.php
@@ -14,7 +14,7 @@
      */
     public function up(): void
     {
-        Schema::table('users', function (Blueprint $table) {
+        Schema::table('users', function (Blueprint $table): void {
             $table->text('two_factor_secret')
                 ->after('password')
                 ->nullable();
@@ -36,7 +36,7 @@ public function up(): void
      */
     public function down(): void
     {
-        Schema::table('users', function (Blueprint $table) {
+        Schema::table('users', function (Blueprint $table): void {
             $table->dropColumn(array_merge([
                 'two_factor_secret',
                 'two_factor_recovery_codes',

diff --git a/database/migrations/2016_06_01_000001_create_oauth_auth_codes_table.php b/database/migrations/2016_06_01_000001_create_oauth_auth_codes_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('oauth_auth_codes', function (Blueprint $table) {
+        Schema::create('oauth_auth_codes', function (Blueprint $table): void {
             $table->string('id', 100)->primary();
             $table->foreignUuid('user_id')->index();
             $table->uuid('client_id');

diff --git a/database/migrations/2016_06_01_000002_create_oauth_access_tokens_table.php b/database/migrations/2016_06_01_000002_create_oauth_access_tokens_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('oauth_access_tokens', function (Blueprint $table) {
+        Schema::create('oauth_access_tokens', function (Blueprint $table): void {
             $table->string('id', 100)->primary();
             $table->foreignUuid('user_id')->nullable()->index();
             $table->uuid('client_id');

diff --git a/database/migrations/2016_06_01_000003_create_oauth_refresh_tokens_table.php b/database/migrations/2016_06_01_000003_create_oauth_refresh_tokens_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('oauth_refresh_tokens', function (Blueprint $table) {
+        Schema::create('oauth_refresh_tokens', function (Blueprint $table): void {
             $table->string('id', 100)->primary();
             $table->string('access_token_id', 100)->index();
             $table->boolean('revoked');

diff --git a/database/migrations/2016_06_01_000004_create_oauth_clients_table.php b/database/migrations/2016_06_01_000004_create_oauth_clients_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('oauth_clients', function (Blueprint $table) {
+        Schema::create('oauth_clients', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->foreignUuid('user_id')->nullable()->index();
             $table->string('name');

diff --git a/database/migrations/2016_06_01_000005_create_oauth_personal_access_clients_table.php b/database/migrations/2016_06_01_000005_create_oauth_personal_access_clients_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('oauth_personal_access_clients', function (Blueprint $table) {
+        Schema::create('oauth_personal_access_clients', function (Blueprint $table): void {
             $table->bigIncrements('id');
             $table->uuid('client_id');
             $table->timestamps();

diff --git a/database/migrations/2018_08_08_100000_create_telescope_entries_table.php b/database/migrations/2018_08_08_100000_create_telescope_entries_table.php
@@ -26,7 +26,7 @@ public function up(): void
         }
         $schema = Schema::connection($this->getConnection());
 
-        $schema->create('telescope_entries', function (Blueprint $table) {
+        $schema->create('telescope_entries', function (Blueprint $table): void {
             $table->bigIncrements('sequence');
             $table->uuid('uuid');
             $table->uuid('batch_id');
@@ -43,7 +43,7 @@ public function up(): void
             $table->index(['type', 'should_display_on_index']);
         });
 
-        $schema->create('telescope_entries_tags', function (Blueprint $table) {
+        $schema->create('telescope_entries_tags', function (Blueprint $table): void {
             $table->uuid('entry_uuid');
             $table->string('tag');
 
@@ -56,7 +56,7 @@ public function up(): void
                 ->onDelete('cascade');
         });
 
-        $schema->create('telescope_monitoring', function (Blueprint $table) {
+        $schema->create('telescope_monitoring', function (Blueprint $table): void {
             $table->string('tag')->primary();
         });
     }

diff --git a/database/migrations/2019_08_19_000000_create_failed_jobs_table.php b/database/migrations/2019_08_19_000000_create_failed_jobs_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('failed_jobs', function (Blueprint $table) {
+        Schema::create('failed_jobs', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->uuid('uuid')->unique();
             $table->text('connection');

diff --git a/database/migrations/2019_12_14_000001_create_personal_access_tokens_table.php b/database/migrations/2019_12_14_000001_create_personal_access_tokens_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('personal_access_tokens', function (Blueprint $table) {
+        Schema::create('personal_access_tokens', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->morphs('tokenable');
             $table->string('name');

diff --git a/database/migrations/2020_05_21_100000_create_organizations_table.php b/database/migrations/2020_05_21_100000_create_organizations_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('organizations', function (Blueprint $table) {
+        Schema::create('organizations', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->foreignUuid('user_id')->index();
             $table->string('name');

diff --git a/database/migrations/2020_05_21_200000_create_organization_user_table.php b/database/migrations/2020_05_21_200000_create_organization_user_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('organization_user', function (Blueprint $table) {
+        Schema::create('organization_user', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->foreignUuid('organization_id');
             $table->foreignUuid('user_id');

diff --git a/database/migrations/2020_05_21_300000_create_organization_invitations_table.php b/database/migrations/2020_05_21_300000_create_organization_invitations_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('organization_invitations', function (Blueprint $table) {
+        Schema::create('organization_invitations', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->foreignUuid('organization_id')
                 ->constrained()

diff --git a/database/migrations/2024_01_16_161030_create_sessions_table.php b/database/migrations/2024_01_16_161030_create_sessions_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('sessions', function (Blueprint $table) {
+        Schema::create('sessions', function (Blueprint $table): void {
             $table->string('id')->primary();
             $table->foreignUuid('user_id')->nullable()->index();
             $table->string('ip_address', 45)->nullable();

diff --git a/database/migrations/2024_01_20_110218_create_clients_table.php b/database/migrations/2024_01_20_110218_create_clients_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('clients', function (Blueprint $table) {
+        Schema::create('clients', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->string('name', 255);
             $table->uuid('organization_id');

diff --git a/database/migrations/2024_01_20_110439_create_projects_table.php b/database/migrations/2024_01_20_110439_create_projects_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('projects', function (Blueprint $table) {
+        Schema::create('projects', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->string('name', 255);
             $table->string('color', 16);

diff --git a/database/migrations/2024_01_20_110444_create_tasks_table.php b/database/migrations/2024_01_20_110444_create_tasks_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('tasks', function (Blueprint $table) {
+        Schema::create('tasks', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->string('name', 500);
             $table->uuid('project_id');

diff --git a/database/migrations/2024_01_20_110452_create_tags_table.php b/database/migrations/2024_01_20_110452_create_tags_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('tags', function (Blueprint $table) {
+        Schema::create('tags', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->string('name', 255);
             $table->uuid('organization_id');

diff --git a/database/migrations/2024_01_20_110837_create_time_entries_table.php b/database/migrations/2024_01_20_110837_create_time_entries_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('time_entries', function (Blueprint $table) {
+        Schema::create('time_entries', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->string('description', 500);
             $table->dateTime('start');

diff --git a/database/migrations/2024_03_26_171253_create_project_members_table.php b/database/migrations/2024_03_26_171253_create_project_members_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('project_members', function (Blueprint $table) {
+        Schema::create('project_members', function (Blueprint $table): void {
             $table->uuid('id')->primary();
             $table->integer('billable_rate')->unsigned()->nullable();
             $table->uuid('project_id');

diff --git a/database/migrations/2024_04_11_150130_create_jobs_table.php b/database/migrations/2024_04_11_150130_create_jobs_table.php
@@ -13,7 +13,7 @@
      */
     public function up(): void
     {
-        Schema::create('jobs', function (Blueprint $table) {
+        Schema::create('jobs', function (Blueprint $table): void {
             $table->bigIncrements('id');
             $table->string('queue')->index();
             $table->longText('payload');