Add roles for project members; Restrict access to sensitive project v… #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
============================================
+ Coverage 85.08% 85.19% +0.10%
- Complexity 1107 1123 +16
============================================
Files 198 198
Lines 6089 6133 +44
============================================
+ Hits 5181 5225 +44
Misses 908 908 ☔ View full report in Codecov by Sentry. |
Onatcer
reviewed
Sep 30, 2024
| enum ProjectMemberRole: string | ||
| { | ||
| case Manager = 'manager'; | ||
| case Normal = 'normal'; |
There was a problem hiding this comment.
maybe "member" instead of "normal"?
Onatcer
force-pushed
the
feature/roles_for_project_members
branch
from
507f026
to
6c4256b
Compare
|
I'll close this for now. We plan on implementing project member roles in the future, but we decided against this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alues