Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the sandbox using the version of Rails coming from the Gemfile #5551

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 13, 2023

Summary

Until we're supporting Rails 7.1 bin/sandbox won't work unmodified.

With this change it will use any Rails version is currently used by the top level gemfile, making it the single source of truth.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Dec 13, 2023
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Dec 13, 2023
@elia elia marked this pull request as ready for review December 13, 2023 18:02
@elia elia requested a review from a team as a code owner December 13, 2023 18:02
@elia elia requested a review from rainerdema December 13, 2023 18:02
@elia elia merged commit 2dfb06e into main Dec 13, 2023
2 checks passed
@elia elia deleted the elia/sandbox-rails-version branch December 13, 2023 18:06
@tvdeyen tvdeyen added backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

💚 All backports created successfully

Status Branch Result
v4.1
v4.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 3, 2024

💚 All backports created successfully

Status Branch Result
v4.1
v4.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants