Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Open edit and new forms in dialog with turbo frame #6046

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
+761 −1,494

Admin product properties: Load modal with turbo frame

ec72503
Select commit
Loading
Failed to load commit list.
Open

[Admin] Open edit and new forms in dialog with turbo frame #6046

Admin product properties: Load modal with turbo frame
ec72503
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 0s

89.47% (-0.12%) compared to 06a1148, passed because coverage increased by 0.11% when compared to adjusted base (89.35%)

View this Pull Request on Codecov

89.47% (-0.12%) compared to 06a1148, passed because coverage increased by 0.11% when compared to adjusted base (89.35%)

Details

Codecov Report

Attention: Patch coverage is 97.36842% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (06a1148) to head (ec72503).

Files with missing lines Patch % Lines
.../controllers/solidus_admin/resources_controller.rb 97.22% 2 Missing ⚠️
...ontrollers/solidus_admin/stock_items_controller.rb 80.00% 2 Missing ⚠️
...mponents/solidus_admin/resources/base_component.rb 90.00% 1 Missing ⚠️
...nts/solidus_admin/tax_categories/edit/component.rb 0.00% 1 Missing ⚠️
...lidus_admin/users/store_credits/index/component.rb 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6046      +/-   ##
==========================================
- Coverage   89.58%   89.47%   -0.12%     
==========================================
  Files         801      805       +4     
  Lines       18275    17875     -400     
==========================================
- Hits        16371    15993     -378     
+ Misses       1904     1882      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov