Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.2] [admin] Remove previews for non-UI components that didn't add much value #6074

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 15, 2025

Backport

This will backport the following commits from main to v4.2:

Questions ?

Please refer to the Backport tool documentation

@tvdeyen tvdeyen requested a review from a team as a code owner January 15, 2025 17:02
@tvdeyen tvdeyen added backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_admin labels Jan 15, 2025
@tvdeyen tvdeyen removed backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 labels Jan 15, 2025
The coverage shouldn't drop after this change.

(cherry picked from commit d4c83e3)
@tvdeyen tvdeyen force-pushed the backport/v4.2/pr-5592 branch from 29628ce to d219490 Compare January 15, 2025 17:14
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (f622a2c) to head (d219490).
Report is 2 commits behind head on v4.2.

Additional details and impacted files
@@           Coverage Diff           @@
##             v4.2    #6074   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         607      607           
  Lines       14752    14752           
=======================================
  Hits        13109    13109           
  Misses       1643     1643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen
Copy link
Member Author

tvdeyen commented Jan 15, 2025

Need this for #6072

@tvdeyen tvdeyen merged commit 8f41473 into v4.2 Jan 15, 2025
11 checks passed
@tvdeyen tvdeyen deleted the backport/v4.2/pr-5592 branch January 15, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants