-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move permission sets back to app/ #6090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37aadeb
to
e0d3721
Compare
These were already in app, but moved in solidusio#403. At the time of that PR, code reloading was still handled by Rails, so let's see if we can now move them back as Zeitwerk now handles code reloading.
We had two spec files for this functionality.
d956fcf
to
fba1c16
Compare
tvdeyen
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thanks for the house keeping as well.
adammathys
approved these changes
Jan 24, 2025
jarednorman
approved these changes
Jan 27, 2025
mamhoff
added a commit
to mamhoff/solidus_subscriptions
that referenced
this pull request
Jan 31, 2025
With Solidus PR solidusio/solidus#6090 merged, permission sets are not available at boot time. They don't need to be either, we can move them into app/, where they can live as autoloadable classes. This should also work with older Solidus versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were already in app, but moved in #403, attempting to fix #344 (
A copy of Spree::PermissionSets::DefaultCustomer has been removed from the module tree but is still active!
)At the time of that PR, code reloading was still handled by Rails, so let's see if we can now move them back as Zeitwerk now handles code reloading.