-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows Rails 8, updates sqlite in Gemfile to match what CI runs #6091
base: main
Are you sure you want to change the base?
Conversation
@tvdeyen I've got all the tests passing locally, on all 3 databases. Seems like test flake on that one circle run, but I don't have perms to rerun it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjacoby Thank you! re-running specs, I left a question, let me know what you think about it.
@kennyadsl Updated with your suggestion. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6091 +/- ##
==========================================
- Coverage 92.42% 88.70% -3.73%
==========================================
Files 389 829 +440
Lines 8005 17992 +9987
==========================================
+ Hits 7399 15959 +8560
- Misses 606 2033 +1427 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Very much appreciated. Would you mind to rebase with main (and not merge) and squash the fixup into the introducing commit?
@rjacoby Rubocop needs your attention as well 🙏🏻 |
OMG, this is happening much sooner than expected. Thank you so much guys. |
Only send content to tags that support it per Rails 8 deprecations. See: https://github.com/rails/rails/blob/8-0-stable/actionview/CHANGELOG.md#rails-800rc1-october-19-2024 Handle Rails 8 syntax additions to the error text.
@tvdeyen Rebased, but now the project's codecov isn't happy... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Summary
Bumps
Gemfile
andsolidus_core.gemspec
up to support Rails 8.0. Makes minor changes to update code and tests to deal with Rails 8 changes.This required bumping
sqlite3
above 2.0 to get specs to pass; note that the circleci config already required this and was not testing Rails 7.0 for sqlite likely due to this compatibility mismatch.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: