Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Fix issue refunding uncompleted payments #6094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jtapia
Copy link
Contributor

@jtapia jtapia commented Jan 31, 2025

Summary

  • Remove Refund button for uncompleted payments
  • Remove Credit button for payment on void and invalid state

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@jtapia jtapia requested a review from a team as a code owner January 31, 2025 22:56
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Jan 31, 2025
@jtapia
Copy link
Contributor Author

jtapia commented Jan 31, 2025

In favor of #2932

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (ca1ae4d) to head (7e914f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6094      +/-   ##
==========================================
- Coverage   92.42%   88.69%   -3.74%     
==========================================
  Files         389      829     +440     
  Lines        8005    17989    +9984     
==========================================
+ Hits         7399    15956    +8557     
- Misses        606     2033    +1427     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtapia jtapia changed the title Fix issue refunding uncompleted payments [Backend] Fix issue refunding uncompleted payments Jan 31, 2025
@fthobe
Copy link
Contributor

fthobe commented Feb 1, 2025

Hey @jtapia thank you for picking this up again after so much time. Could you also take a look at the coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants