Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wording, typos, license notice & linked to migration guide #6106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Feb 7, 2025

Summary

Following changes have been made:

  • given that the license is identical to parent repository, licensed under was changed
  • integrated link to migration guide
  • fixed some wording to give a more positive drive
  • fixed some typos

Concerns (but doesn't fully fix yet) #6095

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Following changes have been made: 
- given that the license is identical to parent repository, licensed under was changed
- integrated link to migration guide
- fixed some wording to give a more positive drive
- fixed some typos
@fthobe fthobe requested a review from a team as a code owner February 7, 2025 18:17
@github-actions github-actions bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (b367f99) to head (4f2c051).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6106   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         829      829           
  Lines       17992    17992           
=======================================
  Hits        15959    15959           
  Misses       2033     2033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_promotions Changes to the solidus_promotions gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant