[Promotions] Set Flickwerk patches in initializer #6161
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be sure that the app is fully loaded before setting Flickwerk aliases. Otherwise ie. `Spree::Config` includes default class names even if set differently from the Rails app or extensions.
github-actions
bot
added
the
changelog:solidus_promotions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6161 +/- ##
==========================================
+ Coverage 86.64% 88.81% +2.16%
==========================================
Files 514 835 +321
Lines 11891 18153 +6262
==========================================
+ Hits 10303 16122 +5819
- Misses 1588 2031 +443 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Feb 25, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to be sure that the app is fully loaded before setting Flickwerk aliases. Otherwise ie.
Spree::Configincludes default class names even if set differently from the Rails app or extensions.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: