Removes devise initializer from dummy generator

[tvdeyen]

The dummy app generator adds a devise initializer that's disabled in most of the time.

The official solidus_auth_devise gem has it's own devise initializer, that never gets generated in the dummy app, because the generator skips existing devise initializers (what's good, to prevent overwriting in the real host app).

I don't know if this will have any impact on other existing extension, but IMO it shouldn't unless they depend on devise itself.

[jhawthorn]

Sounds reasonable to me 👍

CC @adammathys who I know pointed this out before

[tvdeyen]

I plan to let all Devise controllers inherit from Spree::BaseController, to make it much easier to extend them from solidus_i18n

[cbrunsdon]

I'm also 👍 this but I don't know this area of the code very well. CC'ing @brendandeere and @forkata as well who know it better than myself.

[jhawthorn]

One thing we'll have to check before merging is whether this breaks extensions which depend on auth_devise

[forkata]

I just tested this with solidus_auth_devise and indeed it will install it's devise initializer if this isn't in place.

I also did a quick test with a gem that depends on solidus_auth_devise like @jhawthorn suggested (solidus_virtual_gift_card) and he is right in that case no initializer will be generated and it throws the devise warnings. I believe this was put in place to just prevent those warnings from the original comment here d3d33ae.

Having said that, I do think this should be addressed in solidus_auth not in core, however I don't know how one might go about that. Maybe we need a way for extensions to hook into the dummy app generator :)

[tvdeyen]

@forkata could rake test_app from solidus_virtual_gift_card also run the solidus_auth_devise generator, like in a "real app"? Or the generator from solidus_virtual_gift_card could run the solidus_auth_devise generator, if it's not already present.

TBH I really don't see the core have to know anything about something it does not depend on.

[cbrunsdon]

solidus_virtual_gift_card will error out trying to run tests against this change with the devise token missing (not just throw a warning). Before I'd be for merging this in I think we need a plan for what we're going to do on gems such as those.

I agree this shouldn't be in core, but I'd like an idea on what we're going to do for those other gems.

[cbrunsdon]

Sorry, @forkata corrected me IRL, it is in fact just warning in the test_app, so it won't break specs. I'm 👍 on this change then, we should deal with it eventually but by no means a priority IMO.

[mamhoff]

👍

[cbrunsdon]

Rebased over master for the rspec fixes, trying build again.

[tvdeyen]

Great. Thanks