check shell scripts in github action using shellcheck #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aautio
reviewed
Oct 10, 2022
.github/workflows/shellcheck.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Run ShellCheck | ||
| uses: ludeeus/action-shellcheck@master |
There was a problem hiding this comment.
Pin the exact version of this third party ludeeus/action-shellcheck action with SHA. It would look like this for the current head:
uses: ludeeus/action-shellcheck@b2bbefc2e6b9dcbc6355b85e366c9e55bf8d57e1
See more at: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
There was a problem hiding this comment.
Oh, I hadn't realized that a push triggerd workflow will have a write-access capable GITHUB_TOKEN and a compromised lint action could write to the repo. Good catch.
aautio
reviewed
Oct 10, 2022
| @@ -0,0 +1,16 @@ | |||
| on: | |||
There was a problem hiding this comment.
Here you could say on: push to trigger workflow on any push to any branch. Thus perhaps the qualifier * for branches is not needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.